[vla] fix: Add batch drop-last configuration - #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
batch_drop_lasteasier to configure for VLA training.The option controls whether the final incomplete batch is dropped and is applied consistently to both the sampler and the DataLoader.
Configuration
Default behavior
When no option is specified, the final incomplete batch is preserved:
Enable drop-last
Add the following flag to the training command:
When enabled, the final batch is dropped if it contains fewer samples than the configured batch size.
Explicitly disable drop-last
The behavior can also be explicitly disabled with:
Behavior
batch_drop_lastFalse--batch-drop-lastTrue--no-batch-drop-lastFalseThis configuration is applied to:
For distributed training, enable
--batch-drop-lastwhen every rank should process the same number of full-sized batches.Example Updates
The PI0.5 DDP, ZeRO-1, and FSDP fine-tuning examples now explicitly enable: