[vla, diffusion] perf: fuse FastWAM DiT q/k RMSNorm into F.rms_norm - #136
Merged
nullnonenilNULL merged 1 commit intoJul 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the hand-rolled RMS normalization in
RMSNorm.forwardinloongforge/embodied/model/fastwam/wan/dit.pywithF.rms_norm, which dispatches to the fused ATen kernel. This module normalizes the q/k projections in every self- and cross-attention block of the FastWAM Wan video DiT, so it runs twice per attention op on every layer — a genuinely hot path.The previous implementation expanded into a chain of separate kernels: an fp32 up-cast,
pow,mean,rsqrt, a broadcast multiply, a down-cast, and a final weight multiply. Each step materializes an intermediate that the backward pass then has to keep alive.F.rms_normcollapses the sequence into one fused forward and one fused backward, cutting both launch overhead and activation memory at this spot.Dtype behavior is preserved deliberately.
F.rms_normonly fuses the weight multiply whenweightandxshare a dtype, so when they differ we normalize without the weight and apply the scale separately. That keeps the original promotion rule intact: an fp32 weight over a bf16 activation still yields an fp32 result.Numerics
Normalization still accumulates in fp32 — the fused kernel uses an fp32 accumulator for reduced-precision inputs. The one behavioral difference is ordering in the same-dtype path: the previous code down-cast before multiplying by
weight, whereas the fused kernel scales before the down-cast. Results are therefore very close to, but not bit-identical with, the previous implementation.Impact