[Model] Support Step-3.5-Flash#305
Open
Joeegin wants to merge 1 commit into
Open
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support and stability fixes for Step-3.5-Flash in the Kunlun backend, primarily around MoE routing/scaling and attention metadata handling.
Changes:
- Add
update_block_tabletoKunlunAttentionMetadataBuilderand enforce contiguous prefill Q/K/V slices. - Extend Kunlun fused MoE to support a router scaling factor and improve grouped-TopK parameter validation.
- Add
KUNLUN_DISABLE_SMALL_MOE=1escape hatch to disable the small-MoE fast path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
vllm_kunlun/v1/attention/backends/kunlun_attn.py |
Adds metadata update helper and fixes prefill tensor contiguity; introduces a new stdlib import. |
vllm_kunlun/ops/fused_moe/layer.py |
Plumbs routed scaling factor from the layer into Kunlun fused MoE calls. |
vllm_kunlun/ops/_kunlun_ops.py |
Adds router_scaling_factor, validates grouped-topk params for sigmoid routing, and adds env-var gating for small-MoE path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6e6215c to
1d08e28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Description
*完善路由缩放参数支持
*完善Grouped TopK校验
*添加一个环境变量(KUNLUN_DISABLE_SMALL_MOE),手动设置成1,禁用小规模Moe分支优化(否则会RuntimeError: CUDA error: unspecified launch failure)
*新增update_block_table方法
Doc:
Checklist (Required)
Before submitting this PR, please ensure that all the following items are completed:
pre-commitchecks.git commit -s.PR Type
Please prefix the PR title with one or more of the following labels to help reviewers quickly understand the nature of the change:
[Feature]– New features or enhancements (e.g. Attention, Communicator, Kernel, Worker, etc.)[Bugfix]– Bug fixes[CI/Build]– CI, build system, or infrastructure improvements[Doc]– Documentation updates or fixes[Misc]– Other changes that do not fit the above categories (use sparingly)Detailed Checklist (Click to Expand)
Thank you for contributing to vLLM Kunlun! To help us maintain high code quality and streamline the review process, please ensure your PR meets the following requirements.
1. Code Quality
pre-commit).2. Testing
3. DCO Compliance
This project follows the Developer Certificate of Origin (DCO).
Signed-off-by:line.git commit -sto automatically add the sign-off.4. Review Expectations
During the review process, maintainers may:
We appreciate your patience and collaboration throughout the review process!