[Model][Bugfix] v0.15.1-dev Remove model and bugfix#340
Closed
Joeegin wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Joeegin <3318329726@qq.com>
… switch Signed-off-by: Joeegin <3318329726@qq.com>
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes several Kunlun-local model implementations/registrations and adds a runtime switch to disable the “small MoE” fast-path in the Kunlun fused MoE op.
Changes:
- Add
KUNLUN_DISABLE_SMALL_MOEenvironment flag to bypass the small-token MoE optimization path infused_moe. - Remove redundant model implementation files from
vllm_kunlun/models/(Qwen VL variants, Intern* variants, InternLM2). - Update
vllm_kunlun/models/__init__.pyto stop registering the removed models.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vllm_kunlun/ops/_kunlun_ops.py | Adds env-controlled gate for the small MoE pre-processing fast-path. |
| vllm_kunlun/models/init.py | Removes registry entries for models whose implementations are being deleted. |
| vllm_kunlun/models/qwen3_vl_moe.py | Deleted redundant Kunlun-local Qwen3-VL-MoE model implementation. |
| vllm_kunlun/models/qwen3_vl.py | Deleted redundant Kunlun-local Qwen3-VL model implementation. |
| vllm_kunlun/models/qwen2_vl.py | Deleted redundant Kunlun-local Qwen2-VL model implementation. |
| vllm_kunlun/models/qwen2_5_vl.py | Deleted redundant Kunlun-local Qwen2.5-VL model implementation. |
| vllm_kunlun/models/internvl.py | Deleted Kunlun-local InternVL implementation. |
| vllm_kunlun/models/interns1_vit.py | Deleted Kunlun-local InternS1 ViT implementation. |
| vllm_kunlun/models/interns1.py | Deleted Kunlun-local InternS1 multimodal model implementation. |
| vllm_kunlun/models/internlm2.py | Deleted Kunlun-local InternLM2 implementation. |
| vllm_kunlun/models/intern_vit.py | Deleted Kunlun-local Intern ViT implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
Contributor
Author
|
Superseded by #371. Moving the head branch off Joeegin:main so Joeegin:main can be synchronized with upstream main without losing the unmerged changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


















PR Description
bugfix AttributeError: 'Qwen3VLTextConfig' object has no attribute 'tie_word_embeddings' #306
Checklist (Required)
Before submitting this PR, please ensure that all the following items are completed:
pre-commitchecks.git commit -s.PR Type
Please prefix the PR title with one or more of the following labels to help reviewers quickly understand the nature of the change:
[Feature]– New features or enhancements (e.g. Attention, Communicator, Kernel, Worker, etc.)[Bugfix]– Bug fixes[CI/Build]– CI, build system, or infrastructure improvements[Doc]– Documentation updates or fixes[Misc]– Other changes that do not fit the above categories (use sparingly)Detailed Checklist (Click to Expand)
Thank you for contributing to vLLM Kunlun! To help us maintain high code quality and streamline the review process, please ensure your PR meets the following requirements.
1. Code Quality
pre-commit).2. Testing
3. DCO Compliance
This project follows the Developer Certificate of Origin (DCO).
Signed-off-by:line.git commit -sto automatically add the sign-off.4. Review Expectations
During the review process, maintainers may:
We appreciate your patience and collaboration throughout the review process!