Skip to content

[Feature] improve random_sample #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liwei109 merged 2 commits into from
May 19, 2026
Merged

[Feature] improve random_sample #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd1cb81
improve random_sample.
yuejun-baidu May 18, 2026
3e15755
remove useless "import accumulate"
yuejun-baidu May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vllm_kunlun/ops/fla/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,12 @@ def get_available_device() -> str:


@functools.cache
def _check_platform() -> Literal["nvidia", "amd", "intel", "musa"]:
def _check_platform() -> Literal["nvidia", "amd", "kunlun"]:
device = get_available_device()
mapping = {
"cuda": "nvidia",
"hip": "amd",
"xpu": "intel",
"xpu": "kunlun",
}
# return the mapped value, or the original if not found
return mapping.get(device, device)
Expand Down
8 changes: 0 additions & 8 deletions vllm_kunlun/v1/attention/backends/kunlun_attn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#
import copy
from dataclasses import dataclass
from itertools import accumulate
from typing import (
TYPE_CHECKING,
Any,
Expand Down Expand Up @@ -603,13 +602,6 @@ def build(
seq_lens = common_attn_metadata.seq_lens
seq_lens_cpu = common_attn_metadata.seq_lens_cpu

seq_start_loc = list(accumulate(seq_lens, initial=0))

seq_start_loc_tensor = torch.empty(
len(seq_start_loc), dtype=torch.int32, device=self.device
)
seq_start_loc_tensor.copy_(torch.as_tensor(seq_start_loc, dtype=torch.int32))

kv_lod_cpu = torch.zeros(num_reqs + 1, dtype=torch.int32, device="cpu")
Comment thread
yuejun-baidu marked this conversation as resolved.
kv_lod_cpu[1:] = seq_lens_cpu.to(torch.int32).cumsum(dim=0)
kv_lod_xpu = kv_lod_cpu.to(self.device)
Expand Down
3 changes: 1 addition & 2 deletions vllm_kunlun/v1/sample/ops/topk_topp_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,7 @@ def random_sample(
q = q.clamp(min=1e-12)
else:
for i, generator in generators.items():
q[i].exponential_(generator=generator)

torch.ops.xspeedgate_ops.inplace_exponential(q[i], generator=generator)
return probs.div_(q).argmax(dim=-1).view(-1)


Expand Down
Loading