Skip to content

Kco 32 custom fields #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 590 commits into
base: development3
Choose a base branch
from
Draft

Kco 32 custom fields #3012

wants to merge 590 commits into from

Conversation

FredPeal
Copy link
Contributor

@FredPeal FredPeal commented Feb 6, 2025

General Description

Please include a summary of the changes and the related issue. Highlight key points of the PR, any relevant information, and reasons for making the change.

Related Issue

A link to the ticket or issue that this PR is related to.(if applicable)

Checklist

A checklist of things that should be done before merging this PR. Linked to the ticket or issue that this PR is related to.(if applicable)

  • I have performed a self-review of my code.
  • I have added tests to cover my changes.
  • I have updated the documentation (if needed).
  • My changes generate no new warnings.
  • My changes do not break any existing tests.

Screenshots (if applicable)

Provide screenshots of impactful changes you have made so that the reviewer can quickly understand the changes.

@FredPeal FredPeal marked this pull request as draft February 7, 2025 14:01
$input['field_type_id']
);
$customFieldDto = CustomField::from([
'app' => app(Apps::class),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredPeal use $app

$customFieldModules = CustomFieldsModules::where(
'system_modules_id',
$systemModules->getId()
)->first();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredPeal firstOrFail no?

$input['field_type_id']
);
$customFieldDto = CustomField::from([
'app' => app(Apps::class),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$app

@@ -40,6 +41,10 @@ extend type Mutation @guard {
@field(
resolver: "App\\GraphQL\\Ecosystem\\Mutations\\CustomFields\\CustomFieldMutation@getAll"
)
createCustomFields(input: CustomFieldInput): CustomField
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should return CustomField!

created_at: DateTime!
updated_at: DateTime!
}
extend type Mutation @guard {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredPeal only super admin can do dthis

)
}

extend type Query @guard {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredPeal same here

@@ -11,6 +11,7 @@ input CustomFieldInput {
value: Mixed
system_module_uuid: String!
entity_id: ID!
field_type_id: ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredPeal lets create its own customfield folder

'custom_modules_id' => $this->customFieldEntityValue->customFields->getId(),
'custom_fields_modules_id' => $this->customFieldEntityValue->customFieldsModules->getId(),
'entity_id' => $this->customFieldEntityValue->entity_id,
'value' => $this->customFieldEntityValue->value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredPeal value should be in the first or create no?


public function execute(): CustomFieldsModules
{
$customFieldsModules = CustomFieldsModules::getById(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FredPeal why not just pass the customfieldmodel

kaioken and others added 28 commits February 24, 2025 18:36
[1.x] refactor: import from dev
Merge pull request #3159 from bakaphp/development
refactor: add sku to product variant
Maximo Castro Pou and others added 30 commits March 7, 2025 23:53
Add filter for public results in search suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants