Add support for timeouts #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 29, 2021 10:55
…orter waiting forever on a hung php-fpm. Signed-off-by: Benjamin Ullian <[email protected]>
Signed-off-by: Benjamin Ullian <[email protected]>
Signed-off-by: Benjamin Ullian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the exporter will hang forever on a hung php-fpm that is not accepting on the socket or is not replying with a status page. You can reproduce this by e.g. sending SIGSTOP to the php-fpm processes and seeing that the exporter never reports a failure, rather prometheus starts timing out trying to scrape it.
PR Overview
--status.timeout(env varSTATUS_TIMEOUT) cli flag, defaults to 0 which means no timeout and is the current behavior.github.com/tomasen/fcgi_client => github.com/kanocz/fcgi_clientin go.mod to get a forked fcgi_client module that also supports timeouts. This is basically including Add read/write timeouts tomasen/fcgi_client#12 as a net result.