Skip to content

Conversation

@elshan-eth
Copy link
Collaborator

@elshan-eth elshan-eth commented Jun 2, 2025

Deployment preparation: BalancerFeeBurner

build-info: balancer/balancer-v3-monorepo@e65fc25

Deployment preparation tasks checklist:

  • Deployments README is updated with the new task name and link
  • Task README has a description and links to the artifacts
  • build-info is updated with artifacts compiled at the specified commit
  • Artifacts are generated from build-info
  • New task has a working fork test

Code checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented in tests and scripts
  • Fork test block number and test cases are appropriate for this deployment
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

@elshan-eth elshan-eth changed the title Add deployment stuff for balancer burner [DRAFT] Add deployment stuff for balancer burner Jun 2, 2025
@elshan-eth elshan-eth changed the title [DRAFT] Add deployment stuff for balancer burner [DRAFT] Deployment preparation: BalancerFeeBurner Jun 2, 2025
@elshan-eth elshan-eth changed the title [DRAFT] Deployment preparation: BalancerFeeBurner Deployment preparation: BalancerFeeBurner Jun 2, 2025
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting 6eee562f8ea6f7f230b59212be180dab for build-info.

The branch should be deployment-preparation/balancer-fee-burner.

Needs deployment readme update.

Co-authored-by: EndymionJkb <EndymionJkb@gmail.com>
@elshan-eth elshan-eth closed this Jun 3, 2025
@elshan-eth elshan-eth deleted the 20250530-v3-balancer-fee-burner branch June 3, 2025 15:31
@elshan-eth elshan-eth restored the 20250530-v3-balancer-fee-burner branch June 3, 2025 15:32
@elshan-eth elshan-eth reopened this Jun 3, 2025
@elshan-eth
Copy link
Collaborator Author

Unfortunately, it is not possible to rename it without creating a new PR

@EndymionJkb
Copy link
Collaborator

Unfortunately, it is not possible to rename it without creating a new PR

That's fine; just for future reference!

jubeira
jubeira previously approved these changes Jun 26, 2025
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits addressed, artifacts updated to balancer/balancer-v3-monorepo@e65fc25.

The rest LGTM!

@jubeira jubeira merged commit cdc3b9f into master Jun 26, 2025
47 of 48 checks passed
@jubeira jubeira deleted the 20250530-v3-balancer-fee-burner branch June 26, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants