Case insensitivity: added not and greaterThan tests#53
Open
dmarcelino wants to merge 3 commits into
Open
Conversation
Contributor
|
Looks good ✔️ |
Contributor
Author
|
Thanks @devinivy, once balderdashy/sails-postgresql#156 is fixed I'll merge this one. |
Contributor
Author
|
Mongo still needs fixing, raised balderdashy/sails-mongo#265 and updated the original description. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following balderdashy/sails-mongo#260 (comment) we should add case insensitivity tests for query modifiers
notandgreaterThan.Unfortunately sails-mongo does not pass these tests, so it's probably best we fix balderdashy/sails-mongo#265 before merging this.
Tasks:
⛔ Do not merge yet, this breaks sails-mongo tests : https://travis-ci.org/balderdashy/waterline-adapter-tests/jobs/60676152#L542 ⛔