Test that originalError is set for unique keys#89
Open
kevinburkeshyp wants to merge 1 commit intobalderdashy:masterfrom
Open
Test that originalError is set for unique keys#89kevinburkeshyp wants to merge 1 commit intobalderdashy:masterfrom
originalError is set for unique keys#89kevinburkeshyp wants to merge 1 commit intobalderdashy:masterfrom
Conversation
It's set for WLError, but at least one library clobbers the original error message when creating a WLValidationError. Test that this property exists.
Contributor
Author
|
Sorry, this will pass for sails-postgresql once balderdashy/sails-postgresql#180 is merged. |
Member
|
It's not just sails-postgresql but also https://travis-ci.org/balderdashy/waterline-adapter-tests/jobs/75691934#L606 |
Contributor
|
@dmarcelino merged balderdashy/sails-postgresql#180 so we just need to look at the others. |
particlebanana
added a commit
to balderdashy/sails-mysql
that referenced
this pull request
Feb 5, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's set for WLError, but at least one library clobbers the original error
message when creating a WLValidationError. Test that this property exists.
Um, a little uncertain about the best practice here - I only use/care about one library, and I don't expect this to be implemented anywhere else, though I believe it should be, obviously.
Specifically: sails-postgresql currently creates its own error and discards the native Postgres error when a uniqueness check fails. I would like to keep the Postgres error around as
originalError, the same way it is for any non-23505 && non-"Key ... already exists" error message. This passes for the sails-postgresql adapter (though many other tests fail; haven't looked into why).