Add support for They said so api token #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I will try this out soon! |
lmatter
force-pushed
the
they-said-so-api-token
branch
from
eda32fe to
e356324
Compare
Contributor
Author
|
@klutchell This is the first time I messed with a PR like this; hopefully I did it correctly. |
|
Hey @lmatter I tested this and it works great, thanks! Can you please update the README to reflect that setting the |
Contributor
Author
|
@alanb128 I changed the variable name for consistency with QOD_CATEGORY. |
Contributor
|
@lmatter would you mind squashing these two commits into one, and instead of merging with master perform a rebase on master? Thanks again for the contribution, sorry to make you jump through so many hoops! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You now need an API token to get quote of the day.