Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for requirement labels feature #2922

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

pipex
Copy link
Contributor

@pipex pipex commented Mar 3, 2025

Updates @balena/compose to v7 to include this new feature.

See: https://balena.fibery.io/Work/Project/Refactoring-container-contracts-1205
Depends-on: balena-io-modules/balena-compose#64
Change-type: minor

Release notes

This release introduces support for defining container requirements from composition labels.

Supported labels are

  • io.balena.features.requires.sw.supervisor that should be set to a version range
  • io.balena.features.requires.sw.l4t that should be set to a version range
  • io.balena.features.requires.arch.sw that should be set to a valid architecture (amd64, aarch64, armv7hf, rpi, i386)
  • io.balena.features.requires.hw.device-type that should be set to a valid device type slug (not validated at the moment).

pipex added a commit to balena-io/docs that referenced this pull request Mar 3, 2025
This also removes the container contracts page as this feature is being
replaced by container requirements.

See: https://balena.fibery.io/Work/Project/Refactoring-container-contracts-1205
Change-type: minor
Depends-on: balena-io/balena-cli#2922
@pipex pipex marked this pull request as draft March 3, 2025 18:59
@pipex pipex force-pushed the compose-requirement-labels branch 2 times, most recently from 6955780 to 2a6be7a Compare March 3, 2025 20:03
pipex added a commit to balena-io/docs that referenced this pull request Mar 3, 2025
This also removes the container contracts page as this feature is being
replaced by container requirements.

See: https://balena.fibery.io/Work/Project/Refactoring-container-contracts-1205
Change-type: minor
Depends-on: balena-io/balena-cli#2922
pipex added a commit to balena-io/docs that referenced this pull request Mar 3, 2025
This also removes the container contracts page as this feature is being
replaced by container requirements.

See: https://balena.fibery.io/Work/Project/Refactoring-container-contracts-1205
Change-type: minor
Depends-on: balena-io/balena-cli#2922
@pipex pipex force-pushed the compose-requirement-labels branch from 2a6be7a to 708605f Compare March 6, 2025 19:30
@pipex pipex marked this pull request as ready for review March 6, 2025 19:32
@pipex pipex force-pushed the compose-requirement-labels branch from 708605f to 7108c09 Compare March 12, 2025 13:58
@flowzone-app flowzone-app bot enabled auto-merge March 12, 2025 15:12
@pipex pipex force-pushed the compose-requirement-labels branch from 37fd7f6 to 43ce520 Compare March 12, 2025 15:42
@pipex pipex requested review from thgreasi and myarmolinsky March 12, 2025 16:58
Copy link
Member

@thgreasi thgreasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just change the Bump balena/compose to v7 title commit message to sometjing like build: Add support for the new requirement labels feature so that the new feature shows up in the changelog. Other than that lgtm 👍

@pipex pipex changed the title Bump balena/compose to v7 Add support for requirement labels feature Mar 12, 2025
pipex added 2 commits March 12, 2025 15:30
Depending on the signing password value, the script may interpret the
contents of the password and cause the signing process to fail.

This puts quotes around the password on assignment to prevent this.
@pipex pipex force-pushed the compose-requirement-labels branch from 43ce520 to d24d78d Compare March 12, 2025 18:30
@flowzone-app flowzone-app bot merged commit a904212 into master Mar 12, 2025
60 checks passed
@flowzone-app flowzone-app bot deleted the compose-requirement-labels branch March 12, 2025 19:33
pipex added a commit to balena-io/docs that referenced this pull request Mar 12, 2025
This also removes the container contracts page as this feature is being
replaced by container requirements.

See: https://balena.fibery.io/Work/Project/Refactoring-container-contracts-1205
Change-type: minor
Depends-on: balena-io/balena-cli#2922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants