Skip to content

[2201.12.x] Add support for creating twilio triggers #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LakshanWeerasinghe
Copy link
Contributor

Purpose

$subject

Fixes Add support for Twilio AsyncAPI trigger in BI

Duplicate of #873

Screen.Recording.2025-05-21.at.07.42.45.mov
Screenshot 2025-05-21 at 07 49 53

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Twilio trigger support by introducing new metadata entries for the Twilio trigger in both the service model index generator and the language server extension.

  • Introduces a new trigger.twilio package entry in packages.json for the service model index generator.
  • Updates trigger_properties.json to register trigger.twilio and reindexes the ftp and file entries accordingly.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
service-model-index-generator/src/main/resources/packages.json Added a new trigger.twilio package definition
service-model-generator-ls-extension/src/main/resources/trigger_properties.json Registered trigger.twilio properties and bumped keys for ftp and file
Comments suppressed due to low confidence (3)

service-model-generator/modules/service-model-index-generator/src/main/resources/packages.json:739

  • Add or update unit/integration tests to cover the new Twilio trigger entry, ensuring the index generator correctly processes the 'trigger.twilio' package.
"name": "trigger.twilio"

service-model-generator/modules/service-model-generator-ls-extension/src/main/resources/trigger_properties.json:63

  • Update relevant documentation (e.g., README or extension docs) to include the newly added 'trigger.twilio' properties so that developers are aware of Twilio trigger support in the LS extension.
"name": "trigger.twilio"

service-model-generator/modules/service-model-generator-ls-extension/src/main/resources/trigger_properties.json:72

  • [nitpick] After inserting the new '7' entry for Twilio, ensure that all subsequent numeric keys are incremented consistently to avoid collisions; consider switching to an array structure to improve maintainability.
"8": {

@LakshanWeerasinghe LakshanWeerasinghe merged commit 4ebece9 into ballerina-platform:2201.12.x May 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant