-
Notifications
You must be signed in to change notification settings - Fork 48
Fix issue with form not rendering for Logging functions in the right side panel #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with form not rendering for Logging functions in the right side panel #883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves the issue where the logging functions’ forms were not rendering properly in the right side panel by adding the missing "packageName" property to the logging function call configurations. The changes uniformly update multiple JSON configuration files to include "packageName": "log" for various logging functions.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| available_nodes/config/while1.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/transaction2.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/transaction1.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/resource_connector.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/on_fail_clause1.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/method1.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/match2.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/match1.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/lock1.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/inside_nested_foreach.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/function3.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/function2.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/function1.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/foreach1.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/force_assign.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/connector3.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/connector2.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/connector1.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| available_nodes/config/caller.json | Added "packageName": "log" to FUNCTION_CALL nodes |
| main/resources/functions.json | Added "packageName": "log" to FUNCTION_CALL nodes in functions resource |
Comments suppressed due to low confidence (20)
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/while1.json:325
- The addition of "packageName" is consistent with the logging module invocation. Consider updating the JSON schema documentation to clarify the purpose and expected value of this field.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/transaction2.json:305
- The new "packageName" field should be documented in the JSON schema; ensure that its value 'log' is consistent across all logging function configurations.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/transaction1.json:305
- The inclusion of "packageName" in this configuration should be accompanied by corresponding documentation in the JSON schema for clarity.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/resource_connector.json:17581
- Ensure that the added "packageName" property is reflected in the schema documentation so that its purpose for logging function calls is clear.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/on_fail_clause1.json:305
- The addition of the "packageName" property here is clear; consider adding a comment or documentation note in the schema regarding its usage.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/method1.json:295
- Make sure that the logging configuration now using "packageName" is consistently documented in the schema for maintenance purposes.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/match2.json:305
- Confirm that the addition of "packageName" aligns with the overall API design for logging function calls across your configuration files.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/match1.json:305
- The new field should be reflected in associated documentation to maintain clarity of the logging configuration API.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/lock1.json:305
- Ensure that the "packageName" field’s purpose is clearly documented, as it is a key element for matching logging functions in the UI.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/inside_nested_foreach.json:315
- The addition of "packageName" should be noted in the configuration schema documentation to assist future maintainers.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/function3.json:295
- As with other files, ensure that the purpose of the "packageName" property is documented within the JSON schema for clarity.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/function2.json:305
- Verify that the added "packageName" property is consistently applied and clearly documented as part of the logging configuration API.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/function1.json:305
- Ensure that the new "packageName" field is mentioned in any related documentation updates for the logging configuration.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/foreach1.json:325
- The changes consistently add "packageName"; confirm that the JSON schema or inline documentation reflects its role in logging function calls.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/force_assign.json:305
- Review that the inclusion of "packageName" is uniformly supported by the logging API design and documented in the configuration guidelines.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/connector3.json:379
- Ensure the new "packageName" field is properly defined in the logging configuration schema documentation to aid clarity.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/connector2.json:4782
- Confirm that the addition of "packageName" is consistent with the API design across all configuration files and update documentation accordingly.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/connector1.json:674
- The update adds "packageName" uniformly; ensure that related documentation or the JSON schema provides context for this property.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/available_nodes/config/caller.json:417
- Make sure that the inclusion of "packageName" here is also reflected in any configuration documentation or schema notes for clarity.
"packageName": "log",
flow-model-generator/modules/flow-model-generator-ls-extension/src/main/resources/functions.json:17
- Verify that the functions resource file now includes the "packageName" property and that this change is documented for consumers of the logging API.
"packageName": "log",
69897fa to
ff1e28b
Compare
c615c17
into
ballerina-platform:2201.12.x
Purpose
$subject
Fixes Logging is not working with 2201.12.5
Screen.Recording.2025-05-28.at.11.24.37.mov
Fixes Cannot open function call nodes with 2201.12.5
Screen.Recording.2025-05-28.at.12.15.19.mov