Skip to content

Conversation

@dulajdilshan
Copy link
Contributor

@dulajdilshan dulajdilshan commented May 28, 2025

Purpose

  1. Implement correct behaviour of JSON converted to types

previously our behaviour was:
image

According to new implementation the behaviour is:
image

  1. Refactor previous implementation
  • Use lightweight data objects for evaluation and data parsing purpose (Previously we used SyntaxTree nodes)
  • Convert directly data objects to type-data without applying to the syntax tree and re-create.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Pending..

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@dulajdilshan
Copy link
Contributor Author

Closing this hence ballerina-platform/ballerina-language-server#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant