Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the content of generated md files to be markdown compatible #43925

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thil4n
Copy link

@thil4n thil4n commented Mar 17, 2025

Purpose

This PR fixes the Markdown compatibility issue in the generated readme.md file for bal new -t lib command.

Fixes #42907

Approach

Edit the static file cli/ballerina-cli/src/main/resources/new_cmd_defaults/README.md.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Sorry, something went wrong.

Co-authored-by: Asma Jabir <azinneera@gmail.com>
@azinneera
Copy link
Contributor

The first 2 commit messages can be squashed into one since the messages seem to be the same. The commit message should start with Uppercase and in the imperative mood.

@thil4n
Copy link
Author

thil4n commented Mar 19, 2025

The first 2 commit messages can be squashed into one since the messages seem to be the same. The commit message should start with Uppercase and in the imperative mood.

Ack, Will use proper commit messages.

@thil4n thil4n requested a review from azinneera April 1, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Make the content of generated md files to be markdown compatible
2 participants