Add semantic analysis and negative tests for natural expressions #43993

MaryamZi · 2025-04-09T11:58:51Z

Purpose

$title.

Positive tests will go in the library module.

Fixes #43945

…atform/ballerina-lang into natural-programming

codecov · 2025-04-12T09:48:05Z

Codecov Report

Attention: Patch coverage is 65.36313% with 62 lines in your changes missing coverage. Please review.

Please upload report for BASE (natural-programming@c092499). Learn more about missing BASE report.
Report is 36 commits behind head on natural-programming.

Files with missing lines	Patch %	Lines
.../compiler/semantics/analyzer/DataflowAnalyzer.java	0.00%	10 Missing ⚠️
...piler/tree/expressions/BLangNaturalExpression.java	55.55%	8 Missing ⚠️
...llerinalang/compiler/desugar/ClosureGenerator.java	0.00%	5 Missing ⚠️
...rinalang/compiler/desugar/ConstantPropagation.java	0.00%	5 Missing ⚠️
...2/ballerinalang/compiler/desugar/QueryDesugar.java	0.00%	5 Missing ⚠️
...inalang/compiler/tree/SimpleBLangNodeAnalyzer.java	0.00%	5 Missing ⚠️
...ava/io/ballerina/compiler/api/impl/NodeFinder.java	0.00%	4 Missing ⚠️
...o/ballerina/compiler/api/impl/ReferenceFinder.java	0.00%	4 Missing ⚠️
...a/io/ballerina/compiler/api/impl/SymbolFinder.java	0.00%	4 Missing ⚠️
...lang/compiler/semantics/analyzer/CodeAnalyzer.java	0.00%	4 Missing ⚠️
... and 5 more

Additional details and impacted files

@@                  Coverage Diff                   @@
##             natural-programming   #43993   +/-   ##
======================================================
  Coverage                       ?   74.99%           
  Complexity                     ?    57662           
======================================================
  Files                          ?     3546           
  Lines                          ?   223032           
  Branches                       ?    28868           
======================================================
  Hits                           ?   167264           
  Misses                         ?    46493           
  Partials                       ?     9275

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

SasinduDilshara · 2025-04-13T16:30:30Z

compiler/ballerina-lang/src/main/java/io/ballerina/projects/DocumentContext.java

+                                             String moduleName, DependencyResolutionType dependencyResolutionType) {
+        if (!currentModuleDesc.name().toString().equals(moduleName)) {
+            ModuleLoadRequest moduleLoadRequest = new ModuleLoadRequest(
+                    PackageOrg.from(orgName), moduleName, scope, dependencyResolutionType);


In here Don't we need to consider about the language version
As an example np module can have different versions for U12 and U13

That's resolved by the project API? Which is why we shouldn't specify a version here?

SasinduDilshara · 2025-04-13T16:45:18Z

...rina-lang/src/main/java/io/ballerina/projects/internal/NaturalProgrammingImportAnalyzer.java

+ */
+public class NaturalProgrammingImportAnalyzer extends NodeVisitor {
+
+    private boolean shouldImportNaturalProgrammingModule;


Suggested change

private boolean shouldImportNaturalProgrammingModule;

private boolean shouldImportNaturalProgrammingModule = false;

Updated in #44013.

SasinduDilshara · 2025-04-13T16:46:49Z

...iler/ballerina-lang/src/main/java/org/ballerinalang/util/diagnostic/DiagnosticErrorCode.java

+    EXPECTED_TYPE_FOR_NATURAL_EXPR_MUST_CONTAIN_ERROR("BCE4070", "expected.type.for.natural.expr.must.contain.error"),
+    EXPECTED_TYPE_FOR_NATURAL_EXPR_MUST_CONTAIN_A_UNION_OF_NON_ERROR_AND_ERROR(
+            "BCE4071", "expected.type.for.natural.expr.must.contain.a.union.of.non.error.and.error"),
+    EXPECTED_TYPE_FOR_NATURAL_EXPR_MUST_BE_A_SUBTYPE_OF_ANYDATA_OR_ERROR(


Dont we need to avoid the regexp in here

Why though?

SasinduDilshara · 2025-04-13T16:52:56Z

...g/src/main/java/org/wso2/ballerinalang/compiler/tree/expressions/BLangNaturalExpression.java

+
+    @Override
+    public String toString() {
+        return "BLangNaturalExpression: strings " + strings + ", insertions " + insertions;


Dont we need to construct the original expression in here, Same thing done by the SQL queries

I've kept this consistent with other templates in the language.

SasinduDilshara · 2025-04-13T16:55:45Z

...rina-lang/src/main/java/io/ballerina/projects/internal/NaturalProgrammingImportAnalyzer.java

+        return externalFunctionBodyNode.annotations().stream()
+                .anyMatch(annotation ->
+                        annotation.annotReference() instanceof SimpleNameReferenceNode annotReference &&
+                                CODE_ANNOTATION.equals(annotReference.name().text()));


Since code is a common name, shall we check the prompt field also?

It'll have the module prefix then.

Looks like we don't give a redeclared symbol error for code in the current module. Will fix this for m2.

This is when there is a code annotation in the current module.

MaryamZi · 2025-04-14T13:50:01Z

Adding more tests, WIP.

MaryamZi · 2025-04-16T01:15:52Z

Merging to trigger a timestamped build - will send a separate PR with tests/addressing other suggestions if any.

rdulmina · 2025-04-16T06:46:29Z

...g/src/main/java/org/wso2/ballerinalang/compiler/tree/expressions/BLangNaturalExpression.java

+/*
+ *  Copyright (c) 2025, WSO2 LLC. (http://www.wso2.org).
+ *
+ *  WSO2 Inc. licenses this file to you under the Apache License,


Should be LLC

rdulmina · 2025-04-16T06:47:31Z

...g/src/main/java/org/wso2/ballerinalang/compiler/tree/expressions/BLangNaturalExpression.java

+import java.util.List;
+
+/**
+ * Represents a natural expression.


Represents a natural expression in AST

IMO, self-explanatory, given where it is and the class name.

...g/src/main/java/org/wso2/ballerinalang/compiler/tree/expressions/BLangNaturalExpression.java

...rina-lang/src/main/java/io/ballerina/projects/internal/NaturalProgrammingImportAnalyzer.java

rdulmina · 2025-04-16T07:13:39Z

...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java

+        boolean constNaturalExpr = naturalExpression.constExpr;
+
+        if (!constNaturalExpr && !types.isSubtype(symTable.errorType, expTypeSemType)) {
+            dlog.error(naturalExpression.pos, DiagnosticErrorCode.EXPECTED_TYPE_FOR_NATURAL_EXPR_MUST_CONTAIN_ERROR);


Cant we use the regular incompatible types error here. The main issue is in the error message we say the expected type is incorrect but the position we use for the error msg is the expression pos

That's why I introduced a specific error message. This is a dependently-typed expression, so saying expected anydata found T for the expected type doesn't really work.

My concern is, if we consider an assignment, we are saying that the LHS type is incorrect while giving the error on the RHS.

It's a commn concern with dependently-typed expressions. I think the current error explains the issue better to the user compared to giving an error to the expected type. The error needs to work with all kinds of places in which a natural expression is used.

MaryamZi added 9 commits April 1, 2025 14:03

Introduce semantic changes for natural expressions

1527cbf

Add the np import for natural exprs

64e284d

Merge branch 'natural-programming' of https://github.com/ballerina-pl…

8b8acc9

…atform/ballerina-lang into natural-programming

Merge branch 'natural-programming' of https://github.com/ballerina-pl…

72d03b5

…atform/ballerina-lang into natural-programming

Update for parser changes and update library org

2264928

Introduce the code annotation

c8e9b5b

Refactor code

166824b

Add tests

95980d6

Add basic lang support for compile-time natural programming

88c9c44

MaryamZi requested review from gimantha, hasithaa and sameerajayasoma as code owners April 9, 2025 11:58

MaryamZi closed this Apr 9, 2025

MaryamZi reopened this Apr 9, 2025

Merge branch 'natural-programming' of https://github.com/ballerina-pl…

73daf87

…atform/ballerina-lang into natural-programming

MaryamZi closed this Apr 9, 2025

MaryamZi reopened this Apr 9, 2025

MaryamZi requested review from SasinduDilshara and rdulmina April 9, 2025 15:09

MaryamZi added 2 commits April 9, 2025 23:16

Remove unused imports

736e0d2

Merge branch 'natural-programming' of https://github.com/ballerina-pl…

4748b59

…atform/ballerina-lang into natural-programming

MaryamZi requested a review from KavinduZoysa as a code owner April 11, 2025 17:07

Fix tests

7726ada

MaryamZi force-pushed the natural-programming branch from c8fcb0b to 7726ada Compare April 12, 2025 02:20

SasinduDilshara reviewed Apr 13, 2025

View reviewed changes

Handle natural expression arguments

7af41c9

MaryamZi merged commit 6c68428 into ballerina-platform:natural-programming Apr 16, 2025
19 checks passed

rdulmina reviewed Apr 16, 2025

View reviewed changes

MaryamZi mentioned this pull request Apr 24, 2025

[Task]: Introduce lang changes for natural expressions #43945

Closed

	private boolean shouldImportNaturalProgrammingModule;
	private boolean shouldImportNaturalProgrammingModule = false;

Add semantic analysis and negative tests for natural expressions #43993

Add semantic analysis and negative tests for natural expressions #43993

Uh oh!

Conversation

MaryamZi commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Uh oh!

codecov bot commented Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MaryamZi commented Apr 14, 2025

Uh oh!

MaryamZi commented Apr 16, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MaryamZi commented Apr 9, 2025 •

edited

Loading

codecov bot commented Apr 12, 2025 •

edited

Loading