Skip to content

feat: Remove unwanted rule prefer-returning-shorthand #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximeRougieux merged 4 commits into from
Feb 27, 2026
Merged

feat: Remove unwanted rule prefer-returning-shorthand #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcca63c
refactor: :fire: remove deprecated lint
Feb 27, 2026
b45774a
fix: :rotating_light: example lint
Feb 27, 2026
e6b3bf2
feat: :fire: remove rule for better readability (we do not think .new…
Feb 27, 2026
4333f5f
feat: :bookmark: bump theodo_analysis to 1.11.0
Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

All notable changes to the `theodo_analysis` package will be documented in this file.

## 1.11.0

- feat: Remove the "prefer-returning-shorthands" rule
- feat: Support for dcm 1.35.0 (no new rules, no actual change)

## 1.10.0

- feat: Upgrade dcm to 1.34.0 and add news rules
Expand Down
2 changes: 1 addition & 1 deletion example/lib/example.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
void main() {
/// The following line would normally show a lint warning
/// but we can disable the lint rule for this line using the following syntax.
var greeting = 'hello world'; // ignore: prefer_final_locals
var greeting = 'hello world'; // ignore: prefer_final_locals // <- testing

/// The following line would normally show a lint warning
/// but we can disable the lint rule for this file using `ignore_for_file`.
Expand Down
20 changes: 9 additions & 11 deletions lib/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ analyzer:
inference_failure_on_instance_creation: ignore

exclude:
- 'build/**'
- '**/*.g.dart'
- '**/*.freezed.dart'
- '**/*gicons.dart'
- '**/*.graphql.dart'
- "build/**"
- "**/*.g.dart"
- "**/*.freezed.dart"
- "**/*gicons.dart"
- "**/*.graphql.dart"

linter:
rules:
Expand All @@ -28,7 +28,6 @@ linter:
- always_put_required_named_parameters_first
- always_use_package_imports
- annotate_overrides
- avoid_as
- avoid_bool_literals_in_conditional_expressions
- avoid_catching_errors
- avoid_double_and_int_checks
Expand Down Expand Up @@ -237,12 +236,12 @@ dart_code_metrics:
maximum-nesting-level: 5

metrics-exclude:
- '**/*gicons.dart'
- '**/*.graphql.dart'
- "**/*gicons.dart"
- "**/*.graphql.dart"

rules-exclude:
- '**/*gicons.dart'
- '**/*.graphql.dart'
- "**/*gicons.dart"
- "**/*.graphql.dart"

rules:
- pass-optional-argument:
Expand All @@ -255,7 +254,6 @@ dart_code_metrics:
threshold: 10
- avoid-assigning-notifiers
- use-ref-and-state-synchronously
- prefer-returning-shorthands
- prefer-shorthands-with-static-fields
- prefer-shorthands-with-enums
- avoid-nested-shorthands
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: theodo_analysis
description: Lint and dcm rules for Dart and Flutter used internally at Theodo Apps.
version: 1.10.0
version: 1.11.0
homepage: https://github.com/bamlab/theodo_analysis
repository: https://github.com/bamlab/theodo_analysis

Expand Down