Don't add path to the config when obtained via command lookup#272
Open
ncfavier wants to merge 1 commit intobanacorn:masterfrom
Open
Don't add path to the config when obtained via command lookup#272ncfavier wants to merge 1 commit intobanacorn:masterfrom
ncfavier wants to merge 1 commit intobanacorn:masterfrom
Conversation
ncfavier
force-pushed
the
dont-add-paths
branch
from
4a97b65 to
069327e
Compare
Collaborator
|
LGTM! I think this should be the intended behavior. cc @banacorn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #255. When the Agda executable is discovered by looking up the
agdacommand inPATH, don't store the result in the user's configuration. This makes it possible to switch between environments with different versions of Agda without having to erase the paths every time.