Skip to content

[chore] add catch on run command#35

Merged
RogerKSI merged 5 commits into
masterfrom
add-catch-on-run
Jun 2, 2026
Merged

[chore] add catch on run command#35
RogerKSI merged 5 commits into
masterfrom
add-catch-on-run

Conversation

@RogerKSI

@RogerKSI RogerKSI commented Jun 2, 2026

Copy link
Copy Markdown
Member

Fixed:

  • add catch on run command

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the Rust FFI boundary for execution by catching panics during owasm_vm::run, and updates the crate/dependency versions and CI artifact actions to align with the new release.

Changes:

  • Wrap owasm_vm::run in catch_unwind in do_run to prevent panics from unwinding across the FFI boundary.
  • Bump libgo_owasm crate version and the owasm-vm dependency to 0.3.2.
  • Update GitHub Actions artifact upload/download steps from @v3 to @v4.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

File Description
libgo_owasm/src/lib.rs Adds panic-catching around VM execution and maps outcomes into Error codes.
libgo_owasm/Cargo.toml Bumps crate and owasm-vm dependency versions.
.github/workflows/build.yaml Updates artifact actions to v4 for build outputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread libgo_owasm/Cargo.toml
Comment thread libgo_owasm/src/lib.rs
@RogerKSI RogerKSI requested review from satawatnack and taobun June 2, 2026 11:06
@RogerKSI RogerKSI merged commit e94e479 into master Jun 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants