[chore] add catch on run command#35
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the Rust FFI boundary for execution by catching panics during owasm_vm::run, and updates the crate/dependency versions and CI artifact actions to align with the new release.
Changes:
- Wrap
owasm_vm::runincatch_unwindindo_runto prevent panics from unwinding across the FFI boundary. - Bump
libgo_owasmcrate version and theowasm-vmdependency to0.3.2. - Update GitHub Actions artifact upload/download steps from
@v3to@v4.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
libgo_owasm/src/lib.rs |
Adds panic-catching around VM execution and maps outcomes into Error codes. |
libgo_owasm/Cargo.toml |
Bumps crate and owasm-vm dependency versions. |
.github/workflows/build.yaml |
Updates artifact actions to v4 for build outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
taobun
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed:
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)