Change chart cadence according v1.0.0#1345
Open
ignaciogonzalezsomoza wants to merge 2 commits intobanzaicloud:masterfrom
Open
Change chart cadence according v1.0.0#1345ignaciogonzalezsomoza wants to merge 2 commits intobanzaicloud:masterfrom
ignaciogonzalezsomoza wants to merge 2 commits intobanzaicloud:masterfrom
Conversation
ignaciogonzalezsomoza
requested review from
pregnor and
sagikazarmark
as code owners
|
I suspect that |
prashanthkokati
approved these changes
Feb 29, 2024
karim-oueslati
approved these changes
Mar 1, 2024
ramizpolic
approved these changes
May 14, 2024
ramizpolic
reviewed
May 14, 2024
| dynamicConfig: | ||
| values: {} | ||
| pollInterval: "10s" | ||
| dynamicconfig: |
Member
There was a problem hiding this comment.
any reason why the naming convention changed here? there are parts that still refer to the old snakeCase version. can we revert this to dynamicConfig before merging
|
Anyone Who Will Fix or Approve this? This is Much needed because it's almost 2 years old version latest is V1.2.11 ... It would be great Help :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adapt cadence chart according to the recently released version 1.0.0. This chart has been named with the same version since it is the first jump to version 1.x.x.
The main changes affect the following elements:
Why?
new release of cadence
Checklist