[v2] use gogo protobuf fork #794
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laci21
approved these changes
Nov 20, 2021
Member
Author
|
there are unmarshal issues, i set it to draft for now |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Use
github.com/waynz0r/protobufgogo protobuf full fork and get rid of the replacement directive in go.mod. The protobuf fork was modified to be a full fork with changed import paths.Why?
The fork is needed to support int64/uint64 marshalling to integers. Using the fork with replacement in go.mod made the api hard to use as the replacement was necessary everywhere locally.