Some small README improvements #886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-a-joyce
requested review from
Laci21,
martonsereg and
waynz0r
as code owners
|
|
Laci21
reviewed
Feb 10, 2023
Comment on lines
+77
to
+78
| ``` | ||
| ``` |
Member
There was a problem hiding this comment.
I think this was deliberately one section. First the command and then the output of the command in one section.
| kubectl get pods -n istio-system | ||
| NAME READY STATUS RESTARTS AGE | ||
| istio-operator-controller-manager-7875df958d-v4h7l 2/2 Running 0 17h | ||
| istiod-icp-v116x-sample-7b499b7d-gps2b 1/1 Running 0 17h``` |
Member
There was a problem hiding this comment.
Suggested change
| istiod-icp-v116x-sample-7b499b7d-gps2b 1/1 Running 0 17h``` | |
| istiod-icp-v116x-sample-7b499b7d-gps2b 1/1 Running 0 17h |
| istio-operator-controller-manager-7875df958d-v4h7l 2/2 Running 0 17h | ||
| istiod-icp-v116x-sample-7b499b7d-gps2b 1/1 Running 0 17h``` | ||
| ``` | ||
| Note the `icp-v116x-sample` string in both outputs |
Member
There was a problem hiding this comment.
What do u mean by "both" here exactly? I can only see the string in "istiod-icp-v116x-sample-7b499b7d-gps2b", but not in "istio-operator-controller-manager-7875df958d-v4h7l".
| curl https://raw.githubusercontent.com/istio/istio/master/samples/bookinfo/networking/bookinfo-gateway.yaml | sed 's/istio: ingressgateway # use istio default controller/istio: imgw-sample/g;s/number: 80/number: 9080/g' | kubectl apply -n demoapp -f - | ||
| ``` | ||
| ``` | ||
| $ kubectl -n demoapp apply -f bookinfo-gateway.yaml |
Member
There was a problem hiding this comment.
I don't think this should be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Improves the Readme
Why?
No issue created
None
Checklist
To Do