-
Notifications
You must be signed in to change notification settings - Fork 195
parallel e2e testing with different kubeconfigs #1020
base: master
Are you sure you want to change the base?
Changes from 24 commits
3800d03
1561b6a
d7947cc
d9efd7f
ccc9a6d
f8a786d
56c0634
527e501
0f0e07e
4826fa1
0764631
86586a4
2df49bb
cd250f5
6958dce
347d28d
2b85e9f
b678b17
400c0ff
4c0b935
4031097
edab06c
6f55555
98b4a0d
8b72d6c
5154223
bc10e92
c1fd100
eb7c5a1
a2952f6
95d6371
50d3a81
129e7fe
7029681
7bc2a2d
4c7b111
842273f
ba66727
a13805f
a947c8c
18442f6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,9 @@ on: | |
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| checks: write | ||
| pull-requests: write | ||
|
|
||
| steps: | ||
| - name: Set up Go | ||
|
|
@@ -19,14 +22,41 @@ jobs: | |
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Kind cluster | ||
| id: setup-kind | ||
| - name: Setup Kind cluster1 | ||
| id: setup-kind1 | ||
| uses: ./.github/actions/kind-create | ||
| with: | ||
| kind_cluster_name: kind1 | ||
| kind_k8s_version: v1.24.13 | ||
| kubeconfig_dir_path: tests/e2e/kubeconfigs | ||
|
|
||
| # TODO: ZookeeperCluster create time out always on the second kind cluster | ||
|
||
| # - name: Setup Kind cluster2 | ||
| # id: setup-kind2 | ||
| # uses: ./.github/actions/kind-create | ||
| # with: | ||
| # kind_cluster_name: kind2 | ||
| # kind_k8s_version: v1.25.9 | ||
| # kubeconfig_dir_path: tests/e2e/kubeconfigs | ||
|
|
||
| - name: run tests | ||
| - name: Run E2E tests | ||
| env: | ||
| KUBECONFIG: ${{ steps.setup-kind.outputs.kubeconfig }} | ||
| TEST_STRATEGY: version | ||
| KUBECONFIG_DIR: kubeconfigs | ||
| MAX_TIMEOUT: "1h" | ||
| run: | | ||
| go work init | ||
| go work use -r . | ||
| make test-e2e | ||
|
|
||
| - name: Publish Test Results | ||
| uses: EnricoMi/publish-unit-test-result-action/composite@master | ||
| if: always() | ||
bartam1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| with: | ||
| commit: ${{ github.event.workflow_run.head_sha }} | ||
| report_individual_runs: "true" | ||
| check_name: "E2E test report" | ||
| large_files: true | ||
| comment_mode: off | ||
| files: | | ||
| tests/e2e/reports/e2e_*.xml | ||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -46,16 +46,17 @@ const ( | |||||||
| zookeeperClusterName = "zookeeper-server" | ||||||||
| managedByHelmLabelTemplate = "app.kubernetes.io/managed-by=Helm,app.kubernetes.io/instance=%s" | ||||||||
|
|
||||||||
| cruiseControlPodReadinessTimeout = 50 * time.Second | ||||||||
| kafkaClusterResourceReadinessTimeout = 60 * time.Second | ||||||||
| defaultDeletionTimeout = 20 * time.Second | ||||||||
| defaultPodReadinessWaitTime = 10 * time.Second | ||||||||
| defaultTopicCreationWaitTime = 10 * time.Second | ||||||||
| defaultUserCreationWaitTime = 10 * time.Second | ||||||||
| cruiseControlPodReadinessTimeout = 50 * time.Second | ||||||||
| kafkaClusterResourceReadinessTimeout = 60 * time.Second | ||||||||
| defaultDeletionTimeout = 20 * time.Second | ||||||||
| defaultPodReadinessWaitTime = 10 * time.Second | ||||||||
| defaultTopicCreationWaitTime = 10 * time.Second | ||||||||
| defaultUserCreationWaitTime = 10 * time.Second | ||||||||
|
|
||||||||
| kafkaClusterCreateTimeout = 600 * time.Second | ||||||||
| kafkaClusterResourceCleanupTimeout = 120 * time.Second | ||||||||
| kcatDeleetionTimeout = 40 * time.Second | ||||||||
| zookeeperClusterCreateTimeout = 4 * time.Minute | ||||||||
| zookeeperClusterCreateTimeout = 7 * time.Minute // Increased from 4 to 7 for multiple kind | ||||||||
Kuvesz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| zookeeperClusterCreateTimeout = 7 * time.Minute // Increased from 4 to 7 for multiple kind | |
| // increase timeout for supporting multiple Kind clusters | |
| zookeeperClusterCreateTimeout = 7 * time.Minute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove but in this case who will face with this issue on multiple kind cluster on github will not know what was the original setting for one kind cluster setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think default values and the reason of their changes are valuable in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the increased timeout was not helped, I put back to the original value and I removed the comment
fixed: 129e7fe
Uh oh!
There was an error while loading. Please reload this page.