Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

enable pprof #1039

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

enable pprof #1039

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58e9769
enable pprof
Aug 15, 2023
1dcdf07
suggestions
Aug 18, 2023
156ea95
check returned errors
Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ package main
import (
"context"
"flag"
"net/http"
"net/http/pprof"
"os"
"strings"

Expand Down Expand Up @@ -138,6 +140,7 @@ func main() {
setupLog.Error(err, "unable to start manager")
os.Exit(1)
}
mgr.AddMetricsExtraHandler("/debug/pprof/", http.HandlerFunc(pprof.Index))
Copy link
Contributor

@bartam1 bartam1 Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this like here: https://github.com/kube-logging/logging-operator/blob/8a8a3ec6bd7764653cc049397d253c53b373a2c7/main.go#L158

Copy link
Contributor

@bartam1 bartam1 Aug 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should also add these:

		mgr.AddMetricsExtraHandler("/debug/pprof/cmdline", http.HandlerFunc(pprof.Cmdline))
		mgr.AddMetricsExtraHandler("/debug/pprof/profile", http.HandlerFunc(pprof.Profile))
		mgr.AddMetricsExtraHandler("/debug/pprof/symbol", http.HandlerFunc(pprof.Symbol))
		mgr.AddMetricsExtraHandler("/debug/pprof/trace", http.HandlerFunc(pprof.Trace))


if err := certv1.AddToScheme(mgr.GetScheme()); err != nil {
setupLog.Error(err, "")
Expand Down