Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add dynamic params to AvatarComponent #312

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

k0va1
Copy link
Contributor

@k0va1 k0va1 commented Jul 21, 2023

As a PoC I've added dynamic params to AvatarComponent. Now it's possible to change them on the fly

According to the #180

Here you can see how it looks like:
image

@k0va1 k0va1 force-pushed the avatar_component_with_params branch from ad3d098 to 49a1387 Compare July 21, 2023 16:32
@kirillplatonov
Copy link
Collaborator

It works great! The only thing I noticed is that params not included in source won't make any impact on preview (eg Size in Default preview). Maybe it will be better to have a showcase of all possible params in "Default" preview? And in other previews allow to change only params that are included in source?

We could also add "Basic" preview and use it to show the most simple usage example (that's what our current "Default" preview does). What do you think?

@k0va1
Copy link
Contributor Author

k0va1 commented Jul 25, 2023

Yep, my bad. Forgot to pass size param to component

I like the idea of changing only source params, I think it will be more straightforward and easier to understand for users.

We could also add "Basic" preview and use it to show the most simple usage example (that's what our current "Default" preview does). What do you think?

Agree, added all available params to the Default preview and created a Basic preview

@k0va1 k0va1 force-pushed the avatar_component_with_params branch 2 times, most recently from 9a7435e to 1b849e6 Compare July 25, 2023 14:15
@k0va1 k0va1 force-pushed the avatar_component_with_params branch from 1b849e6 to 21195dc Compare July 25, 2023 14:16
@kirillplatonov
Copy link
Collaborator

Looks great. Thanks!

@kirillplatonov kirillplatonov merged commit 76344a8 into baoagency:main Jul 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants