Repository navigation
Conversation
Stock SM puts a disk's SR uuid under the VBD backend's sm-data/mem-pool: every vbd3 node on two x86_64 XCP-ng lab hosts has it. rawfile writes the same uuid as sm-data/sr-uuid only, so a tool that follows the stock key finds the disk's VDI but not its SR. xentop-ng is one: it files the guest disk under an SR named "/dev" (the directory of /dev/loop0) and shows the rawfile SR with no disk. Write mem-pool as well, with the same value. sr-uuid stays: the xcp-rrdd-iostat change on the riscv xen-api branch reads it, and renaming it would break disk stats until that changes too. Tested on the RISC-V dom0 with this rawfileSR installed and riscv1 started: the VBD node has mem-pool and sr-uuid, both the SR uuid. xentop-ng (with its sm-data change for blkback backends) shows the disk under SR "Disk" (rawfile) as VDI trixie-root, and the SR with one VBD. xcp-rrdd-iostat still feeds the SR data sources (io_throughput_write_<sr>, iops_write_<sr> change between two reads). Signed-off-by: Bruno Verachten <gounthar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stock SM puts a disk's SR uuid under the VBD backend's
sm-data/mem-pool; every vbd3 node on two x86_64 XCP-ng lab hosts has it. rawfile only writessm-data/sr-uuid, so a tool that follows the stock key finds the VDI but not the SR. xentop-ng is one: it files the guest disk under an SR named/devand shows the rawfile SR with no disk.This writes
mem-pooltoo, same value.sr-uuidstays, because the xcp-rrdd-iostat change on the riscv xen-api branch reads it.Tested on the RISC-V dom0 with riscv1 running: the VBD node has both keys, xentop-ng (with olivierlambert/xentop-ng#21) shows the disk under SR
Diskas VDItrixie-root, and the iostat SR data sources still move between two reads.This work was assisted by an LLM.