Skip to content

Conversation

agorman
Copy link
Contributor

@agorman agorman commented May 28, 2023

…re closed properly by call to wait

This would solve #68. I haven't fixed the failing tests yet and wanted to get your opinion.

Thanks!

@agorman
Copy link
Contributor Author

agorman commented Jun 19, 2023

@barasher any thoughts on this?

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: -1.35 ⚠️

Comparison is base (b9a9a53) 80.80% compared to head (97132af) 79.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   80.80%   79.46%   -1.35%     
==========================================
  Files           2        2              
  Lines         297      297              
==========================================
- Hits          240      236       -4     
- Misses         40       42       +2     
- Partials       17       19       +2     
Impacted Files Coverage Δ
exiftool.go 70.95% <50.00%> (-1.91%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@barasher
Copy link
Owner

barasher commented Jul 4, 2023

I'm so sorry @agorman, I really did not have time to check it yet. I'm running out of time these last week's but it should be better in one or two weeks.
I do not forget this PR.

@agorman
Copy link
Contributor Author

agorman commented Jul 4, 2023

@barasher thanks for the update. I'm not in a big hurry on this so don't stress about it. When you have some extra time take a look.

Thanks!

@agorman
Copy link
Contributor Author

agorman commented Nov 10, 2023

@barasher bump :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants