Merged
Conversation
Contributor
|
Thanks for your great work, it would also be nice to have some simple A/AAAA tests in the regular section. The regular section has to use the mock DNS server and not the local one via getaddrinfo, |
cspiel1
force-pushed
the
test_dns_aaaa
branch
from
d21a5f9 to
638b376
Compare
cspiel1
force-pushed
the
test_dns_aaaa
branch
from
638b376 to
73fbcc4
Compare
alfredh
reviewed
Feb 16, 2026
Collaborator
Author
You're welcome. I'll try some simple tests in the regular section tomorrow. |
- adds test_dns_reg with some simple query and DNS cache tests - moves the cleanup tests to the regular section
Contributor
|
this looks very good |
cspiel1
force-pushed
the
test_dns_aaaa
branch
from
d3c4232 to
fd5b8bf
Compare
Collaborator
Author
|
This is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests also AAAA dns queries.
@alfredh I tried to move the dns test from integration to regular and got a lot of troubles with mem stat checks. For now I'd like to concentrate on the dns failures mentioned here #1512.
Next step would be to add a test that sends A+AAAA queries in parallel, similar to
src/sip/request.c.