Skip to content

Make r+ remove try bit#110

Open
Manishearth wants to merge 1 commit intobarosl:masterfrom
Manishearth:tryfix
Open

Make r+ remove try bit#110
Manishearth wants to merge 1 commit intobarosl:masterfrom
Manishearth:tryfix

Conversation

@Manishearth
Copy link
Contributor

try followed by r+ doesn't work without a try- otherwise

r? @barosl

@barosl
Copy link
Owner

barosl commented Nov 7, 2015

Hmm, the logic behind the current try handling is currently very confusing, and may require refactoring. But, AFAICT, try followed by r+ should work when the PR hits the top of the queue, because the try flag will be cleared at that time. Am I missing something?

@Manishearth
Copy link
Contributor Author

I think that misses the case where new commits have been pushed since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments