Skip to content

Dockerize#561

Open
florensie wants to merge 4 commits into
barronwaffles:masterfrom
florensie:master
Open

Dockerize#561
florensie wants to merge 4 commits into
barronwaffles:masterfrom
florensie:master

Conversation

@florensie
Copy link
Copy Markdown

No description provided.

@sepalani
Copy link
Copy Markdown
Collaborator

AFAICT, your last commit for custom domains won't work for users not using Docker. Could you please provide an alternative or an equivalent approach not to break their config?

@pakoito
Copy link
Copy Markdown

pakoito commented Jun 29, 2022

It uses an enviro variable, non-docker users should be able to set it too without any major changes to their config.

HOST=nintendowifi.net python master_server.py

I'd use a more unique name in case of conflicts, i.e. DWC_HOST

@sepalani
Copy link
Copy Markdown
Collaborator

It uses an enviro variable, non-docker users should be able to set it too without any major changes to their config.

HOST=nintendowifi.net python master_server.py

I'd use a more unique name in case of conflicts, i.e. DWC_HOST

This approach is not trivial for Windows users as they most likely use GUI tools rather than CLI. Especially, for Apache. Moreover Apache provides a Define directive to set variables. Finally, Docker isn't that straight forward on Windows that it is on Linux.

@florensie
Copy link
Copy Markdown
Author

florensie commented Jul 24, 2022

Please be aware that this will likely only work on linux anyways, as it requires the host network mode. Otherwise I'd have to figure out which UDP ports need to be bound.

@MisterSheeple
Copy link
Copy Markdown

This PR probably isn't getting merged anytime soon. Fork possible?

@florensie
Copy link
Copy Markdown
Author

This is already a fork, that's how most PRs work. https://github.com/florensie/dwc_network_server_emulator

@MisterSheeple
Copy link
Copy Markdown

I know, I just meant a full fork for including this and some of the other PRs/issues that aren't being fixed, so that there's a chance someone could actively work on the project again

@florensie
Copy link
Copy Markdown
Author

If someone wants to work on the project, they will. I don't see how that has anything to do with this PR.

@loopedice
Copy link
Copy Markdown

@florensie could you please explain if this part is needed if I only intend to have this server only visible in LAN/VPN?

ENV DWC_HOST=nintendowifi.net

@florensie
Copy link
Copy Markdown
Author

IIRC, DWC_HOST needs to be set for this to work at all. Either you use the default and set up a local DNS/hosts file to re-route traffic to that domain. Or you need to set your own domain name, and patch your ROM (or use a cheat in Dolphin?) to use that domain instead of Nintendo's.

@spagootie
Copy link
Copy Markdown

Why won't you guys merge this? Getting your software that uses python 2.7 to work is already maddening and I am not going to run Ubuntu 16.04, an operating system i was running when I was 12 years old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants