start integrating Qodana

.github/workflows/qodana.yaml

@@ -0,0 +1,28 @@
+name: Qodana
+
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - master
+
+  pull_request:
+
+jobs:
+  main:
+    runs-on: ubuntu-latest
+
+    permissions:
+      contents: write
+      pull-requests: write
+      checks: write
+
+    steps:
+      - uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+
+      - name: Qodana Scan
+        uses: JetBrains/qodana-action@v2025.3
+        with:
+          pr-mode: false

.gitignore

@@ -6,6 +6,8 @@ build/
 
 .idea/**
 !.idea/vcs.xml
+!.idea/codeStyles/
+!.idea/codeStyles/**
 !.idea/dictionaries/
 !.idea/dictionaries/**
 !.idea/runConfigurations/

interpreter/src/commonMain/kotlin/tech/pacia/starlarkt/interpreter/runtime/types.kt

@@ -551,7 +551,7 @@ public value class StarTuple(
 @JvmInline
 public value class StarDict(
     // Map keys must be hashable.
-    // In Starlark, hashable values include None, Booleans, numbers, strings, and bytes, and tuples composed from hashable values.
+    // In Starlark, hashable values include None, Booleans, numbers, strings, and bytes, and tuples composed of hashable values.
     // Most mutable values, such as lists, dictionaries, and sets, are not hashable, unless they are frozen.
     // Attempting to use a non-hashable value as a key in a dictionary results in a dynamic error.
     // Idea: check hashability at insertion time.
@@ -593,6 +593,7 @@ public value class StarDict(
 
     override fun iterator(): Iterator<StarValue> = contents.keys.iterator()
 
+    @Suppress("DuplicatedCode") // It is too eager – 2 duplicates are fine. See IJPL-231960.
     public companion object {
         public val methods: Map<String, StarBuiltinFunction<StarDict>> = mapOf(
             "clear" to StarBuiltinFunction("clear") { _, fn, args, kwargs ->
@@ -632,6 +633,7 @@ public value class StarSet(
     override fun iterator(): Iterator<StarValue> = contents.iterator()
 
     public companion object {
+        @Suppress("DuplicatedCode") // It is too eager – 2 duplicates are fine. See IJPL-231960.
         public val methods: Map<String, StarBuiltinFunction<StarSet>> = mapOf(
             "clear" to StarBuiltinFunction("clear") { _, fn, args, kwargs ->
                 if (fn.receiver == null) throw RuntimeError(message = "receiver must not be null")

qodana.yaml

@@ -0,0 +1,8 @@
+version: "1.0"
+linter: jetbrains/qodana-jvm-community:2025.3
+
+profile:
+  name: qodana.recommended
+
+include:
+  - name: IncorrectFormatting

settings.gradle.kts

@@ -9,7 +9,9 @@ pluginManagement {
 }
 
 dependencyResolutionManagement {
+    @Suppress("UnstableApiUsage") // See https://github.com/gradle/gradle/issues/32443
     repositoriesMode = RepositoriesMode.FAIL_ON_PROJECT_REPOS
+    @Suppress("UnstableApiUsage") // See https://github.com/gradle/gradle/issues/32443
     repositories {
         mavenCentral()
     }