This repository was archived by the owner on Jan 12, 2026. It is now read-only.
feat: TIPS Metering RPC #22
Merged
Merged
Conversation
wlawt
reviewed
Nov 10, 2025
cody-wang-cb
approved these changes
Nov 24, 2025
|
|
||
| impl ResourceMetering { | ||
| pub(crate) fn insert(&self, tx: TxHash, metering_info: MeterBundleResponse) { | ||
| let to_remove = if self.data.lru.is_full() { |
There was a problem hiding this comment.
nit: do we need to add a metric or log when it's full
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
RPC's to send metering information to op-rbuilder. To make sure this never blocks the build loop, I did a handful of comparisons between different datastructures/locks:
** This was a custom implementation and while the fastest, I felt like the additional code wasn't worth it over using a DashMap it also has the downside of not being a live view on the data (whereas dashmap is)
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test