fix(ui): sidebar motion, theme switch flicker, and skeleton spacing - #112
Open
barvian wants to merge 15 commits into
Open
fix(ui): sidebar motion, theme switch flicker, and skeleton spacing#112barvian wants to merge 15 commits into
barvian wants to merge 15 commits into
Conversation
Focus rings hug the footer labels, and the nav clip lets first/last outlines paint without extra padding. Co-authored-by: Cursor <cursoragent@cursor.com>
Stamp next-themes' global transition:none lock in an insertion effect around the data-theme write so the switch and tokens flip in one frame. Co-authored-by: Cursor <cursoragent@cursor.com>
It now follows html[data-theme] on first paint, and the page-wide no-transition stamp no longer overrides its 180ms slide. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
Drop @radix-ui/react-tooltip now that InfoTooltip, LifecycleTooltip, and the benchmark tooltip share Base UI's Provider / Positioner / Popup anatomy. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
html[data-theme]on first paint and page colors do not tween/and/upgradesloading skeletons for spacingMade with Cursor