chore: fixed logEventWithContext implementation for better readability
#1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟡 Heimdall Review Status
|
|
@0xkg is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
@0xkg Thanks for contributing! Adding this to our backlog, pending to be reviewed. 👍 |
|
wbnns pls merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
I replaced the
logEventWithContext: function () { return undefined; }withlogEventWithContext: () => {}, which is a cleaner and more concise way to define an empty function in TypeScript. This improves code readability by removing the redundantreturn undefined.Notes to reviewers
The change is purely structural and does not affect the function's behavior. Please review to ensure no side effects have been introduced.
How has it been tested?
No functional tests are required since the change only affects the code's syntax and readability. However, I have verified that the code compiles correctly without issues.