Allow for falsey values to be set in config - #133
Open
bschrag620 wants to merge 2 commits into
Open
Conversation
bschrag620
marked this pull request as ready for review
February 13, 2025 18:15
Author
|
@jorgemanrubia Do you mind taking a look at this and the related issue? |
chaadow
approved these changes
Jan 5, 2026
keshavbiswa
reviewed
Aug 5, 2026
| def set_from(properties) | ||
| properties.each do |key, value| | ||
| public_send("#{key}=", value) if value.present? | ||
| public_send("#{key}=", value) |
There was a problem hiding this comment.
I think removing this works, but in any case checking for a nil value might be safer if we were to add a nil value to the keys.
Suggested change
| public_send("#{key}=", value) | |
| public_send("#{key}=", value) unless value.nil? |
There are plenty of other fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting the config from an initializer a
Rails.application.reloader.to_prepareblock, falsey config values are not honored. The audits1984 config assignment is structured slightly differently, which has been done since the code was originally added.By aligning how the config values are set in
config#set_fromto match how audits1984 does it, falsey values can now be properly assigned.Fixes #134