Fix direct upload to use account-scoped endpoint#7
Merged
Conversation
The upstream Fizzy API (PR #2079) now requires the account slug in the direct upload path. Updated to use account_path() for the Active Storage direct uploads endpoint. Closes #5
waynemsmith
added a commit
to Concurrent-Systems/fizzy-cli
that referenced
this pull request
Mar 28, 2026
uploadFile() returned signed_id (ActiveStorage blob reference) but used it as the sgid in <action-text-attachment>. The API returns a separate attachable_sgid field which is the correct ActionText signed global ID. Also forward direct_upload.headers from the API response instead of manually constructing them — picks up Content-Disposition header. Closes basecamp#7 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/rails/active_storage/direct_uploadsto/{account}/rails/active_storage/direct_uploadsfizzy upload filecommand now works against the production APICloses #5
Test plan
fizzy upload fileworks against production API