Conversation
There was a problem hiding this comment.
Pull request overview
Updates Skiff’s deployment scaffolding to target Kamal 2 defaults, using Kamal secrets and the built-in local registry instead of remote registry credentials.
Changes:
- Switch templating from
.envto.kamal/secretsand add.kamaldirectory creation. - Update deploy config to use Kamal 2 local registry (
localhost:5555) and secret env wiring. - Refresh docs/ignores to reflect secrets-based configuration and Kamal 1 → 2 upgrade step.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/skiff/templates/site.rb | Generates .kamal directory and secrets file instead of .env. |
| lib/skiff/templates/dotfiles/kamal-secrets.tt | Defines the secrets template containing GIT_URL. |
| lib/skiff/templates/dotfiles/gitignore | Ignores .kamal/secrets* (and still ignores .env). |
| lib/skiff/templates/dotfiles/dockerignore | Excludes .kamal/secrets* from Docker build context. |
| lib/skiff/templates/config/deploy.yml.tt | Adjusts env secrets + configures local registry + healthcheck path. |
| lib/skiff/templates/README.md.tt | Documents Kamal 2 upgrade + secrets + local registry expectations. |
| kamal-skiff.gemspec | Pins kamal dependency to ~> 2.0. |
| README.md | Updates user-facing deploy/staging docs for Kamal 2 + secrets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Ignore local secrets | ||
| /.kamal/secrets* | ||
| /.env |
There was a problem hiding this comment.
The comment now only mentions local secrets, but the section still ignores /.env. Consider either updating the comment to mention both secrets and env files, or splitting into two commented sections so the ignore list remains self-explanatory.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.