Add .git to dockerignore and clone git repo inside the image#4
Open
haberbyte wants to merge 1 commit into
Open
Add .git to dockerignore and clone git repo inside the image#4haberbyte wants to merge 1 commit into
haberbyte wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some authentication problems inside the container when building the image with Github Actions. I am guessing it is because some other credentials were pre-setup in the
.git/configat the time of the docker build. Pulling with my fine-grained token then didn't work anymore inside the container.Not sure if I am missing something, but currently it seems to depend on your local
.gitfolder at the time of the docker build if things work. This PR fixes it by ignoring the.git/folder and cloning the bare repo on first boot.