Add Logging Helpers for Improved Traceability #464
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nareshrajkumar866
approved these changes
May 23, 2025
|
Hi, @nareshrajkumar866, thanks for approving this PR. I removed the app-chrome-beta example. I'm running an updater in parallel to keep up with the main project and have the setup I need. If you have anything that interests you, just let me know, and I will open a PR. |
Kasui92
reviewed
May 24, 2025
nareshrajkumar866
approved these changes
May 24, 2025
Kasui92
reviewed
May 26, 2025
There was a problem hiding this comment.
Once you have added the shared folder and the helpers file, you don't need to do this check.
It makes sense to assume it's there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a shared logging utility (helpers.sh) for Omakub installation.
Simple functions (setup_log, log_message) that can be reused across all scripts.
Rationale
Making troubleshooting much easier.