Merged
Conversation
Co-authored-by: milos-dukic <milos-dukic@users.noreply.github.com> Co-authored-by: jjasghar <jjasghar@users.noreply.github.com>
monorkin
force-pushed
the
install-system-dependencies-durign-setup
branch
from
db19c0e to
72c51e6
Compare
This was referenced Sep 15, 2025
eirvandelden
pushed a commit
to eirvandelden/once-campfire
that referenced
this pull request
Dec 14, 2025
Co-authored-by: milos-dukic <milos-dukic@users.noreply.github.com> Co-authored-by: jjasghar <jjasghar@users.noreply.github.com>
Peyochanchan
referenced
this pull request
in Peyochanchan/once-campfire
Apr 13, 2026
Co-authored-by: milos-dukic <milos-dukic@users.noreply.github.com> Co-authored-by: jjasghar <jjasghar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few PRs that focus on documenting dependencies - see #15 and #41
Our internal convention is to have bin/setup handle installing all dependencies for you.
So I've updated the command to install all system dependencies on Mac, Debian and Arch.
In addition, I also made the command spin up a docker container with Redis is Redis isn't already running on the default port.
Closes #15
Closes #41