Store only key-value pairs in Hash arrays - #1341
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes Hash#toArray so it returns only flattened key-value pairs and keeps the packaged Action Text asset synchronized.
Changes:
- Removes the nested
pushthat inserted array lengths. - Rebuilds the generated Action Text bundle.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/trix/core/collections/hash.js |
Corrects Hash#toArray. |
action_text-trix/app/assets/javascripts/trix.js |
Synchronizes the generated asset. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| for (const key in this.values) { | ||
| const value = this.values[key] | ||
| result.push(result.push(key, value)) | ||
| result.push(key, value) |
Author
|
Added the requested exact regression assertion for Hash({ a: 1, b: 2 }).toArray(). ESLint passes and the JavaScript and test bundles build successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the nested
result.pushinHash#toArray.The inner push already appends the key and value; pushing its numeric return value again inserts cumulative array lengths. The corrected method produces the intended flat key/value sequence while preserving the serialized JSON output.
The generated Action Text asset is rebuilt with the same one-line change.
Verification
["a", 1, 2, "b", 2, 5]becomes["a", 1, "b", 2]; JSON remains identicalNo public API or dependency change.