Sanitize markdown output in edit history and TOC edit views - #392
Merged
Conversation
The edit history view and TOC edit partial render Markdown content via to_html without passing through sanitize_content(), unlike the normal page view. This allows stored XSS via img onerror payloads for anyone who can view the edit history of a page with injected content. Apply sanitize_content() consistently to all to_html output, matching the existing safe pattern in leafables/show.html.erb.
There was a problem hiding this comment.
Pull request overview
This PR hardens page rendering against XSS by sanitizing HTML output for page bodies, including in the edit history view and page thumbnails, and adds regression tests to verify dangerous attributes are stripped.
Changes:
- Sanitize rendered HTML for both “previous version” and “current” page bodies in the page edit history view.
- Sanitize rendered HTML for page thumbnails in the leaves edit partial.
- Add controller/integration tests ensuring dangerous attributes (e.g.,
onerror) are removed from rendered output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/views/pages/edits/show.html.erb |
Sanitizes HTML output for both the selected edit’s page body and the current page body. |
app/views/leaves/_edit.html.erb |
Sanitizes page-body HTML used in the leaf thumbnail preview. |
test/controllers/pages/edits_controller_test.rb |
Adds tests covering sanitization for previous and current versions. |
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The edit history view and TOC edit partial render Markdown content via to_html without passing through sanitize_content(), unlike the normal page view. This allows stored XSS via img onerror payloads for anyone who can view the edit history of a page with injected content.
Apply sanitize_content() consistently to all to_html output, matching the existing safe pattern in leafables/show.html.erb.