This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Support for NS Subdomain Prefix #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is based off the previous pull for docker support... if this won't work, I can recreate another branch based off of |
|
One issue is that ns1 also parses as a base36 name for 97.120.0.0, so actually asking for the A records would also return that value. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default is
ns-1,ns-2, etc... this allows the user to override the prefix so that ifXIP_NS_SUBDOMAIN_PREFIX="alternative-ns"the resulting NS records would bealternative-ns1,alternative-ns2, etc (intentionally using an odd name for clarity). In my use cause, usingns01,ns02, etc fits existing naming schema and needed to be able to override the default.