fix: restore stale test scripts - #653
Open
Santiagocetran wants to merge 1 commit into
Open
Conversation
Contributor
|
@Santiagocetran is attempting to deploy a commit to the xmcp Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's going on
pnpm run test:buildandpnpm run test:clidon't work right now. They call two scripts (scripts/test-build.shandscripts/test-cli.sh) that don't exist in the repo anymore.I dug into the git history and found it: back in November, commit
1d18395e("upd bundle analyzer metrics script") deleted these two test scripts as a side effect. That commit was really about adding an unrelated bundle-analyzer script, so this looks like an accidental cleanup rather than a deliberate decision. Nobody updatedpackage.jsonafterward either, so the commands were just left pointing at files that no longer existed. Since then, they've quietly been broken with nobody noticing.Why bring them back
They're the only thing that actually verifies the CLIs work end to end locally, that
xmcp,create-xmcp-app, andinit-xmcpbuild correctly and can each do their basic job (help output, scaffolding a project, initializing one in place). Without them,pnpm run ci(the command you'd normally reach for before opening a PR) silently fails on step one. There's a separatetest-split-e2e.shscript for runtime/compiler testing, but it doesn't cover the CLIs at all, so it's not a substitute.What this PR does
init-xmcpnot existing yet).package.jsonentries that were built around the old broken scripts.DEVELOPMENT.mdso the docs match what these commands actually do.Testing
Ran
test:build,test:cli,test:ci, andci:build-onlylocally end to end, all pass. Worth notingtest:clineeds Node 22+ and does real (small) npm installs into a scratch folder, so it takes a bit longer than a typical script.