Merged
Conversation
…内にHelperのnamespaceとclassnameの変更処理を移動
namespaceとクラス名変更を1つの関数にまとめた。helperが複数あっても対応可能にした。helperの名前がテーマ名と違っても対応可能にした。
…s into baserproject#3978 # Conflicts: # plugins/baser-core/src/Service/ThemesService.php
Collaborator
|
@IwasakiRyuichi ありがとうございます。テスト良い感じです。マージしますね。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ryuring
ユニットテスト作成してみました。
namespaceやclass名に__をつけて存在しないものに変更してみてエラーの表示も確認できました。
レビューをお願いいたします。