Skip to content

Fix path traversal in download_external_data containment guard #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lollinng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix path traversal in download_external_data containment guard #2486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions truss/util/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ def download_external_data(external_data: Optional[ExternalData], data_dir: Path
b10cp_path = _b10cp_path()

# ensure parent directories exist
data_dir_resolved = data_dir.resolve()
for item in external_data.items:
path = data_dir / item.local_data_path
if data_dir not in path.parents:
# resolve before the containment check so ".." cannot escape data_dir
path = (data_dir / item.local_data_path).resolve()
if path != data_dir_resolved and data_dir_resolved not in path.parents:
raise ValueError(
"Local data path of external data cannot point to outside data directory"
)
Expand Down