RTS-1602 fix #346
Merged
RTS-1602 fix #346
+36
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paegun
approved these changes
Jan 18, 2017
|
Yeah that'll be for the next PR that encompasses fixing all of the timeouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional 500ms to client-side timeouts where appropriate. If the server-side timeout is the same value as the client-side one, tests that expect an error of
<<"timeout">>may receive the client-sidetimeoutatom instead (see this test)Note: I'm going to review the timeout usage throughout the code to make sure that if a server-side timeout is in effect, the client-side one is 500ms longer.
@paegun - this branch is complete enough that it should resolve the
verify_api_timeoutsin your environment at this point.