suggested fix for HA2025 deprecation warnings #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
MrEbbinghaus
approved these changes
Jan 28, 2025
|
Resolves: #1144 |
basnijholt
reviewed
Jan 28, 2025
| and ATTR_COLOR_TEMP_KELVIN in service_data | ||
| ): | ||
| # ATTR_COLOR_TEMP and ATTR_COLOR_TEMP_KELVIN are mutually exclusive | ||
| del service_data[ATTR_COLOR_TEMP] |
There was a problem hiding this comment.
Why can this code be deleted?
There was a problem hiding this comment.
ATTR_COLOR_TEMP is now deprecated and services are now using only ATTR_COLOR_TEMP_KELVIN. Therefore it is not required anymore.
There was a problem hiding this comment.
For context: ATTR_COLOR_TEMP_KELVIN was added and ATTR_COLOR_TEMP deprecated in 2022.11 (see home-assistant/core#79591)
There was a problem hiding this comment.
@basnijholt can we get this, #1207 and #1159 merged? Everything seems to be working properly on my end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to update the code without diving to deep in to it.
Basically I just updated as suggested by the warnings in the HA log and keeping the naming in the
supportedset....