Auto update and expand _lights class variable in AdaptiveSwitch on access
#562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th3w1zard1
changed the title
_lights class variable in AdaptiveSwitch_lights class variable in AdaptiveSwitch on access (replaces _expand_light_groups)
th3w1zard1
changed the title
_lights class variable in AdaptiveSwitch on access (replaces _expand_light_groups)_lights class variable in AdaptiveSwitch on access
basnijholt
reviewed
Apr 10, 2023
| data, | ||
| ) | ||
|
|
||
| def __getattribute__(self, name): |
Owner
There was a problem hiding this comment.
what about creating a property on the switch:
@property
def all_lights(self):
return self._expand_light_groups()
then use switch.all_lights everywhere?
Or maybe just lights (I not already in use in HA somewhere).
Collaborator
Author
There was a problem hiding this comment.
We'd have to modify all the references with this method.
Owner
There was a problem hiding this comment.
I see your reasoning :)
However, a custom __getattribute__ might be hard to overlook when debugging because it is not super obvious what happens from just looking at the code.
Collaborator
Author
There was a problem hiding this comment.
I'm not looking forward to modifying the other PRs. Perhaps we merge this one last?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed arbitrary or unnecessarily picky when
switch.pywould used_expand_light_groups()before using_lights, now it just auto-expands on each access.Code also uses
switch._lightsmore sparingly and only once per method.I also added
# pylint: disable=protected-accessto any function that accessed a class method outside of the class as that seemed to be what we've been going with.